Commit e4e6c0b0 authored Feb 11, 2019 by Gustavo A. R. Silva Committed by Guenter Roeck Feb 18, 2019

hwmon: (f71882fg) Mark expected switch fall-through



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’:
drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
    data->auto_point_temp_signed = 1;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/hwmon/f71882fg.c:2459:3: note: here
   case f71889fg:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 45034e48

drivers/hwmon/f71882fg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2455,7 +2455,7 @@ static int f71882fg_probe(struct platform_device *pdev)
		case f71869a:
		/* These always have signed auto point temps */
		data->auto_point_temp_signed = 1;
		/* Fall through to select correct fan/pwm reg bank! */
		/* Fall through - to select correct fan/pwm reg bank! */
		case f71889fg:
		case f71889ed:
		case f71889a:

Admin message