Commit e4d753d7 authored Sep 21, 2017 by Sagi Grimberg Committed by Jens Axboe Sep 25, 2017

nvme-rdma: don't fully stop the controller in error recovery



By calling nvme_stop_ctrl on a already failed controller will wait for the
scan work to complete (only by identify timeout expiration which is 60
seconds). This is unnecessary when we already know that the controller has
failed.

Reported-by: Yi Zhang <yizhan@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0a960afd

drivers/nvme/host/rdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -967,7 +967,7 @@ static void nvme_rdma_error_recovery_work(struct work_struct *work)
		struct nvme_rdma_ctrl *ctrl = container_of(work,
		struct nvme_rdma_ctrl, err_work);

		nvme_stop_ctrl(&ctrl->ctrl);
		nvme_stop_keep_alive(&ctrl->ctrl);

		if (ctrl->ctrl.queue_count > 1) {
		nvme_stop_queues(&ctrl->ctrl);

Admin message