[SCSI] scsi:hosts.c Fix warning: variable 'rval' set but not used (e4bf25fb) · Commits · 戴 / test

The below patch fixes a warning message generated by gcc 4.6.0 CC drivers/scsi/hosts.o drivers/scsi/hosts.c: In function 'scsi_host_alloc': drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used Fix this by removing the rval but placing a printk warning where it would have been set. Signed-off-by:

Justin P. Mattock <justinmattock@gmail.com> Signed-off-by:

James Bottomley <James.Bottomley@suse.de>

drivers/scsi/hosts.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -325,7 +325,6 @@ struct Scsi_Host scsi_host_alloc(struct scsi_host_template sht, int privsize)
		{
		struct Scsi_Host *shost;
		gfp_t gfp_mask = GFP_KERNEL;
		int rval;

		if (sht->unchecked_isa_dma && privsize)
		gfp_mask \|= __GFP_DMA;
		@@ -420,7 +419,8 @@ struct Scsi_Host scsi_host_alloc(struct scsi_host_template sht, int privsize)
		shost->ehandler = kthread_run(scsi_error_handler, shost,
		"scsi_eh_%d", shost->host_no);
		if (IS_ERR(shost->ehandler)) {
		rval = PTR_ERR(shost->ehandler);
		printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n",
		shost->host_no, PTR_ERR(shost->ehandler));
		goto fail_kfree;
		}

Admin message