mwifiex: 11n_rxreorder: Use setup_timer (e4a1c3f8) · Commits · 戴 / test

Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/ ) // <smpl> @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.function = f; -t.data = d; // </smpl> Signed-off-by:

Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/mwifiex/11n_rxreorder.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -391,10 +391,8 @@ mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private priv, u8 ta,
		new_node->timer_context.priv = priv;
		new_node->timer_context.timer_is_set = false;

		init_timer(&new_node->timer_context.timer);
		new_node->timer_context.timer.function = mwifiex_flush_data;
		new_node->timer_context.timer.data =
		(unsigned long) &new_node->timer_context;
		setup_timer(&new_node->timer_context.timer, mwifiex_flush_data,
		(unsigned long)&new_node->timer_context);

		for (i = 0; i < win_size; ++i)
		new_node->rx_reorder_ptr[i] = NULL;

Admin message