Commit e499a9b6 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

x86/kvmclock: Move kvmclock vsyscall param and init to kvmclock 



There is no point to have this in the kvm code itself and call it from
there. This can be called from an initcall and the parameter is cleared
when the hypervisor is not KVM.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarPavel Tatashin <pasha.tatashin@oracle.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Cc: steven.sistare@oracle.com
Cc: daniel.m.jordan@oracle.com
Cc: linux@armlinux.org.uk
Cc: schwidefsky@de.ibm.com
Cc: heiko.carstens@de.ibm.com
Cc: john.stultz@linaro.org
Cc: sboyd@codeaurora.org
Cc: hpa@zytor.com
Cc: douly.fnst@cn.fujitsu.com
Cc: peterz@infradead.org
Cc: prarit@redhat.com
Cc: feng.tang@intel.com
Cc: pmladek@suse.com
Cc: gnomes@lxorguk.ukuu.org.uk
Cc: linux-s390@vger.kernel.org
Cc: boris.ostrovsky@oracle.com
Cc: jgross@suse.com
Link: https://lkml.kernel.org/r/20180719205545.16512-7-pasha.tatashin@oracle.com
parent 42f8df93

arch/x86/include/asm/kvm_guest.h

deleted100644 → 0
+0 −7
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef _ASM_X86_KVM_GUEST_H

#define _ASM_X86_KVM_GUEST_H



int kvm_setup_vsyscall_timeinfo(void);



#endif /* _ASM_X86_KVM_GUEST_H */

arch/x86/kernel/kvm.c

+0 −13
Original line number Diff line number Diff line
@@ -45,7 +45,6 @@ 
#include <asm/apic.h>

#include <asm/apicdef.h>

#include <asm/hypervisor.h>

#include <asm/kvm_guest.h>



static int kvmapf = 1;
@@ -66,15 +65,6 @@ static int __init parse_no_stealacc(char *arg) 


early_param("no-steal-acc", parse_no_stealacc);



static int kvmclock_vsyscall = 1;

static int __init parse_no_kvmclock_vsyscall(char *arg)

{

        kvmclock_vsyscall = 0;

        return 0;

}



early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);



static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);

static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64);

static int has_steal_clock = 0;
@@ -560,9 +550,6 @@ static void __init kvm_guest_init(void) 
	if (kvm_para_has_feature(KVM_FEATURE_PV_EOI))

		apic_set_eoi_write(kvm_guest_apic_eoi_write);



	if (kvmclock_vsyscall)

		kvm_setup_vsyscall_timeinfo();



#ifdef CONFIG_SMP

	smp_ops.smp_prepare_cpus = kvm_smp_prepare_cpus;

	smp_ops.smp_prepare_boot_cpu = kvm_smp_prepare_boot_cpu;

arch/x86/kernel/kvmclock.c

+27 −17
Original line number Diff line number Diff line
@@ -27,12 +27,14 @@ 
#include <linux/sched/clock.h>

#include <linux/mm.h>



#include <asm/hypervisor.h>

#include <asm/mem_encrypt.h>

#include <asm/x86_init.h>

#include <asm/reboot.h>

#include <asm/kvmclock.h>



static int kvmclock __initdata = 1;

static int kvmclock_vsyscall __initdata = 1;

static int msr_kvm_system_time __ro_after_init = MSR_KVM_SYSTEM_TIME;

static int msr_kvm_wall_clock __ro_after_init = MSR_KVM_WALL_CLOCK;

static u64 kvm_sched_clock_offset __ro_after_init;
@@ -44,6 +46,13 @@ static int __init parse_no_kvmclock(char *arg) 
}

early_param("no-kvmclock", parse_no_kvmclock);



static int __init parse_no_kvmclock_vsyscall(char *arg)

{

	kvmclock_vsyscall = 0;

	return 0;

}

early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);



/* Aligned to page sizes to match whats mapped via vsyscalls to userspace */

#define HV_CLOCK_SIZE	(sizeof(struct pvclock_vsyscall_time_info) * NR_CPUS)
@@ -228,6 +237,24 @@ static void kvm_shutdown(void) 
	native_machine_shutdown();

}



static int __init kvm_setup_vsyscall_timeinfo(void)

{

#ifdef CONFIG_X86_64

	u8 flags;



	if (!hv_clock || !kvmclock_vsyscall)

		return 0;



	flags = pvclock_read_flags(&hv_clock[0].pvti);

	if (!(flags & PVCLOCK_TSC_STABLE_BIT))

		return 1;



	kvm_clock.archdata.vclock_mode = VCLOCK_PVCLOCK;

#endif

	return 0;

}

early_initcall(kvm_setup_vsyscall_timeinfo);



void __init kvmclock_init(void)

{

	u8 flags;
@@ -272,20 +299,3 @@ void __init kvmclock_init(void) 
	clocksource_register_hz(&kvm_clock, NSEC_PER_SEC);

	pv_info.name = "KVM";

}
 


int __init kvm_setup_vsyscall_timeinfo(void)

{

#ifdef CONFIG_X86_64

	u8 flags;



	if (!hv_clock)

		return 0;



	flags = pvclock_read_flags(&hv_clock[0].pvti);

	if (!(flags & PVCLOCK_TSC_STABLE_BIT))

		return 1;



	kvm_clock.archdata.vclock_mode = VCLOCK_PVCLOCK;

#endif

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE