Commit e4991b24 authored by Rik van Riel's avatar Rik van Riel Committed by Ingo Molnar
Browse files

Revert 095bebf6 ("sched/numa: Do not move past the balance point if unbalanced") 



Commit 095bebf6 ("sched/numa: Do not move past the balance point
if unbalanced") broke convergence of workloads with just one runnable
thread, by making it impossible for the one runnable thread on the
system to move from one NUMA node to another.

Instead, the thread would remain where it was, and pull all the memory
across to its location, which is much slower than just migrating the
thread to where the memory is.

The next patch has a better fix for the issue that 095bebf6 tried
to address.

Reported-by: default avatarJirka Hladky <jhladky@redhat.com>
Signed-off-by: default avatarRik van Riel <riel@redhat.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dedekind1@gmail.com
Cc: mgorman@suse.de
Link: http://lkml.kernel.org/r/1432753468-7785-2-git-send-email-riel@redhat.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 54d27365

kernel/sched/fair.c

+15 −26
Original line number Diff line number Diff line
@@ -1198,11 +1198,9 @@ static void task_numa_assign(struct task_numa_env *env, 
static bool load_too_imbalanced(long src_load, long dst_load,

				struct task_numa_env *env)

{

	long imb, old_imb;

	long orig_src_load, orig_dst_load;

	long src_capacity, dst_capacity;

	long orig_src_load;

	long load_a, load_b;

	long moved_load;

	long imb;



	/*

	 * The load is corrected for the CPU capacity available on each node.
@@ -1215,39 +1213,30 @@ static bool load_too_imbalanced(long src_load, long dst_load, 
	dst_capacity = env->dst_stats.compute_capacity;



	/* We care about the slope of the imbalance, not the direction. */

	load_a = dst_load;

	load_b = src_load;

	if (load_a < load_b)

		swap(load_a, load_b);

	if (dst_load < src_load)

		swap(dst_load, src_load);



	/* Is the difference below the threshold? */

	imb = load_a * src_capacity * 100 -

		load_b * dst_capacity * env->imbalance_pct;

	imb = dst_load * src_capacity * 100 -

	      src_load * dst_capacity * env->imbalance_pct;

	if (imb <= 0)

		return false;



	/*

	 * The imbalance is above the allowed threshold.

	 * Allow a move that brings us closer to a balanced situation,

	 * without moving things past the point of balance.

	 * Compare it with the old imbalance.

	 */

	orig_src_load = env->src_stats.load;

	orig_dst_load = env->dst_stats.load;



	/*

	 * In a task swap, there will be one load moving from src to dst,

	 * and another moving back. This is the net sum of both moves.

	 * A simple task move will always have a positive value.

	 * Allow the move if it brings the system closer to a balanced

	 * situation, without crossing over the balance point.

	 */

	moved_load = orig_src_load - src_load;

	if (orig_dst_load < orig_src_load)

		swap(orig_dst_load, orig_src_load);



	if (moved_load > 0)

		/* Moving src -> dst. Did we overshoot balance? */

		return src_load * dst_capacity < dst_load * src_capacity;

	else

		/* Moving dst -> src. Did we overshoot balance? */

		return dst_load * src_capacity < src_load * dst_capacity;

	old_imb = orig_dst_load * src_capacity * 100 -

		  orig_src_load * dst_capacity * env->imbalance_pct;



	/* Would this change make things worse? */

	return (imb > old_imb);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE