Commit e48d8ed9 authored Oct 25, 2018 by Sagi Grimberg Committed by Doug Ledford Nov 06, 2018

rxe: fix error completion wr_id and qp_num



Error completions must still contain a valid wr_id and
qp_num such that the consumer can rely on. Correctly
fill these fields in receive error completions.

Reported-by: Walker Benjamin <benjamin.walker@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Tested-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 4e588c8d

drivers/infiniband/sw/rxe/rxe_resp.c

+9 −4

Original line number	Diff line number	Diff line
		@@ -841,11 +841,16 @@ static enum resp_states do_complete(struct rxe_qp *qp,

		memset(&cqe, 0, sizeof(cqe));

		wc->wr_id = wqe->wr_id;
		if (qp->rcq->is_user) {
		uwc->status = qp->resp.status;
		uwc->qp_num = qp->ibqp.qp_num;
		uwc->wr_id = wqe->wr_id;
		} else {
		wc->status = qp->resp.status;
		wc->qp = &qp->ibqp;
		wc->wr_id = wqe->wr_id;
		}

		/* fields after status are not required for errors */
		if (wc->status == IB_WC_SUCCESS) {
		wc->opcode = (pkt->mask & RXE_IMMDT_MASK &&
		pkt->mask & RXE_WRITE_MASK) ?

Admin message