Commit e4826a94 authored Sep 16, 2013 by Thomas Meyer Committed by Rob Clark Sep 28, 2013

drm/msm: Odd PTR_ERR usage



The variable priv->kms is not initialized yet.

Found by "scripts/coccinelle/tests/odd_ptr_err.cocci".
PTR_ERR should access the value just tested by IS_ERR.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

parent d8524ae9

drivers/gpu/drm/msm/msm_drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -199,7 +199,7 @@ static int msm_load(struct drm_device *dev, unsigned long flags)
		* imx drm driver on iMX5
		*/
		dev_err(dev->dev, "failed to load kms\n");
		ret = PTR_ERR(priv->kms);
		ret = PTR_ERR(kms);
		goto fail;
		}

Admin message