Commit e46a2879 authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds
Browse files

CMA: migrate mlocked pages 



Presently CMA cannot migrate mlocked pages so it ends up failing to allocate
contiguous memory space.

This patch makes mlocked pages be migrated out.  Of course, it can affect
realtime processes but in CMA usecase, contiguous memory allocation failing
is far worse than access latency to an mlocked page being variable while
CMA is running.  If someone wants to make the system realtime, he shouldn't
enable CMA because stalls can still happen at random times.

[akpm@linux-foundation.org: tweak comment text, per Mel]
Signed-off-by: default avatarMinchan Kim <minchan@kernel.org>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Cc: Michal Nazarewicz <mina86@mina86.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7a71932d

include/linux/mmzone.h

+2 −0
Original line number Diff line number Diff line
@@ -218,6 +218,8 @@ struct lruvec { 
#define ISOLATE_UNMAPPED	((__force isolate_mode_t)0x2)

/* Isolate for asynchronous migration */

#define ISOLATE_ASYNC_MIGRATE	((__force isolate_mode_t)0x4)

/* Isolate unevictable pages */

#define ISOLATE_UNEVICTABLE	((__force isolate_mode_t)0x8)



/* LRU Isolation modes. */

typedef unsigned __bitwise__ isolate_mode_t;

mm/compaction.c

+6 −2
Original line number Diff line number Diff line
@@ -461,6 +461,7 @@ static bool too_many_isolated(struct zone *zone) 
 * @cc:		Compaction control structure.

 * @low_pfn:	The first PFN of the range.

 * @end_pfn:	The one-past-the-last PFN of the range.

 * @unevictable: true if it allows to isolate unevictable pages

 *

 * Isolate all pages that can be migrated from the range specified by

 * [low_pfn, end_pfn).  Returns zero if there is a fatal signal
@@ -476,7 +477,7 @@ static bool too_many_isolated(struct zone *zone) 
 */

unsigned long

isolate_migratepages_range(struct zone *zone, struct compact_control *cc,

			   unsigned long low_pfn, unsigned long end_pfn)

		unsigned long low_pfn, unsigned long end_pfn, bool unevictable)

{

	unsigned long last_pageblock_nr = 0, pageblock_nr;

	unsigned long nr_scanned = 0, nr_isolated = 0;
@@ -602,6 +603,9 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, 
		if (!cc->sync)

			mode |= ISOLATE_ASYNC_MIGRATE;



		if (unevictable)

			mode |= ISOLATE_UNEVICTABLE;



		lruvec = mem_cgroup_page_lruvec(page, zone);



		/* Try isolate the page */
@@ -807,7 +811,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, 
	}



	/* Perform the isolation */

	low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn);

	low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn, false);

	if (!low_pfn || cc->contended)

		return ISOLATE_ABORT;

mm/internal.h

+1 −1
Original line number Diff line number Diff line
@@ -138,7 +138,7 @@ isolate_freepages_range(struct compact_control *cc, 
			unsigned long start_pfn, unsigned long end_pfn);

unsigned long

isolate_migratepages_range(struct zone *zone, struct compact_control *cc,

			   unsigned long low_pfn, unsigned long end_pfn);

	unsigned long low_pfn, unsigned long end_pfn, bool unevictable);



#endif

mm/page_alloc.c

+1 −1
Original line number Diff line number Diff line
@@ -5690,7 +5690,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, 
		if (list_empty(&cc->migratepages)) {

			cc->nr_migratepages = 0;

			pfn = isolate_migratepages_range(cc->zone, cc,

							 pfn, end);

							 pfn, end, true);

			if (!pfn) {

				ret = -EINTR;

				break;

mm/vmscan.c

+2 −2
Original line number Diff line number Diff line
@@ -1009,8 +1009,8 @@ int __isolate_lru_page(struct page *page, isolate_mode_t mode) 
	if (!PageLRU(page))

		return ret;



	/* Do not give back unevictable pages for compaction */

	if (PageUnevictable(page))

	/* Compaction should not handle unevictable pages but CMA can do so */

	if (PageUnevictable(page) && !(mode & ISOLATE_UNEVICTABLE))

		return ret;



	ret = -EBUSY;

CRA Git | Maintained and supported by SUSTech CRA and CCSE