Unverified Commit e45e290a authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

regulator: core: Support passing an initialized GPIO enable descriptor 



We are currently passing a GPIO number from the global GPIO numberspace
into the regulator core for handling enable GPIOs. This is not good
since it ties into the global GPIO numberspace and uses gpio_to_desc()
to overcome this.

Start supporting passing an already initialized GPIO descriptor to the
core instead: leaf drivers pick their descriptors, associated directly
with the device node (or from ACPI or from a board descriptor table)
and use that directly without any roundtrip over the global GPIO
numberspace.

This looks messy since it adds a bunch of extra code in the core, but
at the end of the patch series we will delete the handling of the GPIO
number and only deal with descriptors so things end up neat.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7928b2cb

drivers/regulator/core.c

+16 −9
Original line number Diff line number Diff line
@@ -1937,6 +1937,9 @@ static int regulator_ena_gpio_request(struct regulator_dev *rdev, 
	struct gpio_desc *gpiod;

	int ret;



	if (config->ena_gpiod)

		gpiod = config->ena_gpiod;

	else

		gpiod = gpio_to_desc(config->ena_gpio);



	list_for_each_entry(pin, &regulator_ena_gpio_list, list) {
@@ -1947,14 +1950,17 @@ static int regulator_ena_gpio_request(struct regulator_dev *rdev, 
		}

	}



	if (!config->ena_gpiod) {

		ret = gpio_request_one(config->ena_gpio,

				       GPIOF_DIR_OUT | config->ena_gpio_flags,

				       rdev_get_name(rdev));

		if (ret)

			return ret;

	}



	pin = kzalloc(sizeof(struct regulator_enable_gpio), GFP_KERNEL);

	if (pin == NULL) {

		if (!config->ena_gpiod)

			gpio_free(config->ena_gpio);

		return -ENOMEM;

	}
@@ -4154,8 +4160,9 @@ regulator_register(const struct regulator_desc *regulator_desc, 
			goto clean;

	}



	if ((config->ena_gpio || config->ena_gpio_initialized) &&

	    gpio_is_valid(config->ena_gpio)) {

	if (config->ena_gpiod ||

	    ((config->ena_gpio || config->ena_gpio_initialized) &&

	     gpio_is_valid(config->ena_gpio))) {

		mutex_lock(&regulator_list_mutex);

		ret = regulator_ena_gpio_request(rdev, config);

		mutex_unlock(&regulator_list_mutex);

include/linux/regulator/driver.h

+3 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include <linux/notifier.h>

#include <linux/regulator/consumer.h>



struct gpio_desc;

struct regmap;

struct regulator_dev;

struct regulator_config;
@@ -387,6 +388,7 @@ struct regulator_desc { 
 *                        initialized, meaning that >= 0 is a valid gpio

 *                        identifier and < 0 is a non existent gpio.

 * @ena_gpio: GPIO controlling regulator enable.

 * @ena_gpiod: GPIO descriptor controlling regulator enable.

 * @ena_gpio_invert: Sense for GPIO enable control.

 * @ena_gpio_flags: Flags to use when calling gpio_request_one()

 */
@@ -399,6 +401,7 @@ struct regulator_config { 


	bool ena_gpio_initialized;

	int ena_gpio;

	struct gpio_desc *ena_gpiod;

	unsigned int ena_gpio_invert:1;

	unsigned int ena_gpio_flags;

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE