ASoC: max98373: replace gpio_request with devm_gpio_request (e44f3d49) · Commits · 戴 / test

Use devm_gpio_request() to automatic unroll when fails and avoid resource leaks at error paths. Signed-off-by:

sound/soc/codecs/max98373.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -960,11 +960,11 @@ static int max98373_i2c_probe(struct i2c_client *i2c,

		/* Power on device */
		if (gpio_is_valid(max98373->reset_gpio)) {
		ret = gpio_request(max98373->reset_gpio, "MAX98373_RESET");
		ret = devm_gpio_request(&i2c->dev, max98373->reset_gpio,
		"MAX98373_RESET");
		if (ret) {
		dev_err(&i2c->dev, "%s: Failed to request gpio %d\n",
		__func__, max98373->reset_gpio);
		gpio_free(max98373->reset_gpio);
		return -EINVAL;
		}
		gpio_direction_output(max98373->reset_gpio, 0);