Commit e44ec779 authored Apr 03, 2020 by Lars-Peter Clausen Committed by Jonathan Cameron Apr 19, 2020

iio: xilinx-xadc: Fix ADC-B powerdown



The check for shutting down the second ADC is inverted. This causes it to
be powered down when it should be enabled. As a result channels that are
supposed to be handled by the second ADC return invalid conversion results.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Fixes: bdc8cda1 ("iio:adc: Add Xilinx XADC driver")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent dd6230ba

drivers/iio/adc/xilinx-xadc-core.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -722,13 +722,14 @@ static int xadc_power_adc_b(struct xadc *xadc, unsigned int seq_mode)
		{
		uint16_t val;

		/* Powerdown the ADC-B when it is not needed. */
		switch (seq_mode) {
		case XADC_CONF1_SEQ_SIMULTANEOUS:
		case XADC_CONF1_SEQ_INDEPENDENT:
		val = XADC_CONF2_PD_ADC_B;
		val = 0;
		break;
		default:
		val = 0;
		val = XADC_CONF2_PD_ADC_B;
		break;
		}

Admin message