Commit e4463e49 authored Jun 24, 2020 by Colin Ian King Committed by Greg Kroah-Hartman Jun 25, 2020

staging: most: avoid null pointer dereference when iface is null

In the case where the pointer iface is null then the reporting of this
error will dereference iface when printing an error message causing which
is not ideal. Since the majority of callers to most_register_interface
report an error when -EINVAL is returned a simple fix is to just remove
the error message, I doubt it will be missed.

Addresses-Coverity: ("Dereference after null check")
Fixes: 57562a72 ("Staging: most: add MOST driver's core module")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200624163957.11676-1-colin.king@canonical.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 75d0bf87

drivers/most/core.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1283,10 +1283,8 @@ int most_register_interface(struct most_interface *iface)
		struct most_channel *c;

		if (!iface \|\| !iface->enqueue \|\| !iface->configure \|\|
		!iface->poison_channel \|\| (iface->num_channels > MAX_CHANNELS)) {
		dev_err(iface->dev, "Bad interface or channel overflow\n");
		!iface->poison_channel \|\| (iface->num_channels > MAX_CHANNELS))
		return -EINVAL;
		}

		id = ida_simple_get(&mdev_id, 0, 0, GFP_KERNEL);
		if (id < 0) {