Commit e43c26e1 authored Sep 23, 2020 by Ye Li Committed by Bartosz Golaszewski Sep 24, 2020

gpio: pca953x: Fix uninitialized pending variable



When pca953x_irq_pending returns false, the pending parameter won't
be set. But pca953x_irq_handler continues using this uninitialized
variable as pending irqs and will cause problem.
Fix the issue by initializing pending to 0.

Fixes: 064c73af ("gpio: pca953x: Synchronize interrupt handler properly")
Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 5ad284ab

drivers/gpio/gpio-pca953x.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -814,7 +814,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
		{
		struct pca953x_chip *chip = devid;
		struct gpio_chip *gc = &chip->gpio_chip;
		DECLARE_BITMAP(pending, MAX_LINE);
		DECLARE_BITMAP(pending, MAX_LINE) = {};
		int level;
		bool ret;

Admin message