Commit e429817b authored Mar 17, 2015 by Suzuki K. Poulose Committed by Will Deacon Mar 19, 2015

ARM: perf: reject groups spanning multiple hardware PMUs



The perf core implicitly rejects events spanning multiple HW PMUs, as in
these cases the event->ctx will differ. However this validation is
performed after pmu::event_init() is called in perf_init_event(), and
thus pmu::event_init() may be called with a group leader from a
different HW PMU.

The ARM PMU driver does not take this fact into account, and when
validating groups assumes that it can call to_arm_pmu(event->pmu) for
any HW event. When the event in question is from another HW PMU this is
wrong, and results in dereferencing garbage.

This patch updates the ARM PMU driver to first test for and reject
events from other PMUs, moving the to_arm_pmu and related logic after
this test. Fixes a crash triggered by perf_fuzzer on Linux-4.0-rc2, with
a CCI PMU present:

 ---
CPU: 0 PID: 1527 Comm: perf_fuzzer Not tainted 4.0.0-rc2 #57
Hardware name: ARM-Versatile Express
task: bd8484c0 ti: be676000 task.ti: be676000
PC is at 0xbf1bbc90
LR is at validate_event+0x34/0x5c
pc : [<bf1bbc90>]    lr : [<80016060>]    psr: 00000013
...
[<80016060>] (validate_event) from [<80016198>] (validate_group+0x28/0x90)
[<80016198>] (validate_group) from [<80016398>] (armpmu_event_init+0x150/0x218)
[<80016398>] (armpmu_event_init) from [<800882e4>] (perf_try_init_event+0x30/0x48)
[<800882e4>] (perf_try_init_event) from [<8008f544>] (perf_init_event+0x5c/0xf4)
[<8008f544>] (perf_init_event) from [<8008f8a8>] (perf_event_alloc+0x2cc/0x35c)
[<8008f8a8>] (perf_event_alloc) from [<8009015c>] (SyS_perf_event_open+0x498/0xa70)
[<8009015c>] (SyS_perf_event_open) from [<8000e420>] (ret_fast_syscall+0x0/0x34)
Code: bf1be000 bf1bb380 802a2664 00000000 (00000002)
---[ end trace 01aff0ff00926a0a ]---

Also cleans up the code to use the arm_pmu only when we know that
we are dealing with an arm pmu event.

Cc: Will Deacon <will.deacon@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Peter Ziljstra (Intel) <peterz@infradead.org>
Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

parent 341e42c4

arch/arm/kernel/perf_event.c

+15 −6

Original line number	Diff line number	Diff line
		@@ -259,20 +259,29 @@ out:
		}

		static int
		validate_event(struct pmu_hw_events *hw_events,
		validate_event(struct pmu pmu, struct pmu_hw_events hw_events,
		struct perf_event *event)
		{
		struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
		struct arm_pmu *armpmu;

		if (is_software_event(event))
		return 1;

		/*
		* Reject groups spanning multiple HW PMUs (e.g. CPU + CCI). The
		* core perf code won't check that the pmu->ctx == leader->ctx
		* until after pmu->event_init(event).
		*/
		if (event->pmu != pmu)
		return 0;

		if (event->state < PERF_EVENT_STATE_OFF)
		return 1;

		if (event->state == PERF_EVENT_STATE_OFF && !event->attr.enable_on_exec)
		return 1;

		armpmu = to_arm_pmu(event->pmu);
		return armpmu->get_event_idx(hw_events, event) >= 0;
		}

		@@ -288,15 +297,15 @@ validate_group(struct perf_event *event)
		*/
		memset(&fake_pmu.used_mask, 0, sizeof(fake_pmu.used_mask));

		if (!validate_event(&fake_pmu, leader))
		if (!validate_event(event->pmu, &fake_pmu, leader))
		return -EINVAL;

		list_for_each_entry(sibling, &leader->sibling_list, group_entry) {
		if (!validate_event(&fake_pmu, sibling))
		if (!validate_event(event->pmu, &fake_pmu, sibling))
		return -EINVAL;
		}

		if (!validate_event(&fake_pmu, event))
		if (!validate_event(event->pmu, &fake_pmu, event))
		return -EINVAL;

		return 0;

Admin message