net/mlx5: E-Switch, Prevent ingress rate configuration of uplink rep (e401a184) · Commits · 戴 / test

Since the implementation relies on limiting the VF transmit rate to simulate ingress rate limiting, and since either uplink representor or ecpf are not associated with a VF, we limit the rate limit configuration for those ports. Fixes: ("net/mlx5: E-Switch, add ingress rate support") Signed-off-by:

Eli Cohen <eli@mellanox.com> Reviewed-by:

Roi Dayan <roid@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -4036,6 +4036,13 @@ static int apply_police_params(struct mlx5e_priv *priv, u32 rate,
		u32 rate_mbps;
		int err;

		vport_num = rpriv->rep->vport;
		if (vport_num >= MLX5_VPORT_ECPF) {
		NL_SET_ERR_MSG_MOD(extack,
		"Ingress rate limit is supported only for Eswitch ports connected to VFs");
		return -EOPNOTSUPP;
		}

		esw = priv->mdev->priv.eswitch;
		/* rate is given in bytes/sec.
		* First convert to bits/sec and then round to the nearest mbit/secs.
		@@ -4044,8 +4051,6 @@ static int apply_police_params(struct mlx5e_priv *priv, u32 rate,
		* 1 mbit/sec.
		*/
		rate_mbps = rate ? max_t(u32, (rate * 8 + 500000) / 1000000, 1) : 0;
		vport_num = rpriv->rep->vport;

		err = mlx5_esw_modify_vport_rate(esw, vport_num, rate_mbps);
		if (err)
		NL_SET_ERR_MSG_MOD(extack, "failed applying action to hardware");

Admin message