Commit e3fe44c7 authored Dec 08, 2014 by Joe Perches Committed by Jeff Kirsher Dec 31, 2014

i40e: Fix possible memory leak in i40e_dbg_dump_desc



I didn't notice that return in the code, fix it by
adding a goto out instead to free the memory.

Fixes:

> New smatch warnings:
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joe Perches <joe@perches.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 2184aa3d

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -829,7 +829,7 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n,
		if (desc_n >= ring->count \|\| desc_n < 0) {
		dev_info(&pf->pdev->dev,
		"descriptor %d not found\n", desc_n);
		return;
		goto out;
		}
		if (!is_rx_ring) {
		txd = I40E_TX_DESC(ring, desc_n);
		@@ -855,6 +855,8 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n,
		} else {
		dev_info(&pf->pdev->dev, "dump desc rx/tx <vsi_seid> <ring_id> [<desc_n>]\n");
		}

		out:
		kfree(ring);
		}

Admin message