sched/idle,stop: Remove .get_rr_interval from sched_class (e3e76a6a) · Commits · 戴 / test

The idle task and stop task sched_classes return 0 in this function. The single call site in sched_rr_get_interval() calls p->sched_class->get_rr_interval() only conditional in case it is defined. Otherwise time_slice=0 will be used. The deadline sched class does not define it. Commit ("sched: Make sched_class::get_rr_interval() optional") introduced the default time-slice=0 for sched classes which do not provide this function. So .get_rr_interval for idle and stop sched_class can be removed to shrink the code a little. Signed-off-by:

Dietmar Eggemann <dietmar.eggemann@arm.com> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20200603080304.16548-4-dietmar.eggemann@arm.com

kernel/sched/idle.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -446,11 +446,6 @@ prio_changed_idle(struct rq rq, struct task_struct p, int oldprio)
		BUG();
		}

		static unsigned int get_rr_interval_idle(struct rq rq, struct task_struct task)
		{
		return 0;
		}

		static void update_curr_idle(struct rq *rq)
		{
		}
		@@ -479,8 +474,6 @@ const struct sched_class idle_sched_class = {

		.task_tick = task_tick_idle,

		.get_rr_interval = get_rr_interval_idle,

		.prio_changed = prio_changed_idle,
		.switched_to = switched_to_idle,
		.update_curr = update_curr_idle,

kernel/sched/stop_task.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -102,12 +102,6 @@ prio_changed_stop(struct rq rq, struct task_struct p, int oldprio)
		BUG(); /* how!?, what priority? */
		}

		static unsigned int
		get_rr_interval_stop(struct rq rq, struct task_struct task)
		{
		return 0;
		}

		static void update_curr_stop(struct rq *rq)
		{
		}
		@@ -136,8 +130,6 @@ const struct sched_class stop_sched_class = {

		.task_tick = task_tick_stop,

		.get_rr_interval = get_rr_interval_stop,

		.prio_changed = prio_changed_stop,
		.switched_to = switched_to_stop,
		.update_curr = update_curr_stop,

Admin message