Commit e3e12028 authored Aug 27, 2013 by Andrew Vagin Committed by David S. Miller Aug 29, 2013

tcp: don't apply tsoffset if rcv_tsecr is zero



The zero value means that tsecr is not valid, so it's a special case.

tsoffset is used to customize tcp_time_stamp for one socket.
tsoffset is usually zero, it's used when a socket was moved from one
host to another host.

Currently this issue affects logic of tcp_rcv_rtt_measure_ts. Due to
incorrect value of rcv_tsecr, tcp_rcv_rtt_measure_ts sets rto to
TCP_RTO_MAX.

Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: James Morris <jmorris@namei.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: Patrick McHardy <kaber@trash.net>
Reported-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c7781a6e

net/ipv4/tcp_input.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -3535,7 +3535,10 @@ static bool tcp_parse_aligned_timestamp(struct tcp_sock *tp, const struct tcphdr
		++ptr;
		tp->rx_opt.rcv_tsval = ntohl(*ptr);
		++ptr;
		if (*ptr)
		tp->rx_opt.rcv_tsecr = ntohl(*ptr) - tp->tsoffset;
		else
		tp->rx_opt.rcv_tsecr = 0;
		return true;
		}
		return false;
		@@ -3560,7 +3563,7 @@ static bool tcp_fast_parse_options(const struct sk_buff *skb,
		}

		tcp_parse_options(skb, &tp->rx_opt, 1, NULL);
		if (tp->rx_opt.saw_tstamp)
		if (tp->rx_opt.saw_tstamp && tp->rx_opt.rcv_tsecr)
		tp->rx_opt.rcv_tsecr -= tp->tsoffset;

		return true;
		@@ -5316,7 +5319,7 @@ static int tcp_rcv_synsent_state_process(struct sock sk, struct sk_buff skb,
		int saved_clamp = tp->rx_opt.mss_clamp;

		tcp_parse_options(skb, &tp->rx_opt, 0, &foc);
		if (tp->rx_opt.saw_tstamp)
		if (tp->rx_opt.saw_tstamp && tp->rx_opt.rcv_tsecr)
		tp->rx_opt.rcv_tsecr -= tp->tsoffset;

		if (th->ack) {

Admin message