Commit e3831edd authored Mar 30, 2012 by Srivatsa S. Bhat Committed by Ingo Molnar Mar 31, 2012

sched: Fix incorrect usage of for_each_cpu_mask() in select_fallback_rq()



The function for_each_cpu_mask() expects a *pointer* to struct
cpumask as its second argument, whereas select_fallback_rq()
passes the value itself.

And moreover, for_each_cpu_mask() has been marked as obselete
in include/linux/cpumask.h. So move to the more appropriate
for_each_cpu() variant.

Reported-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Dave Jones <davej@redhat.com>
Cc: Liu Chuansheng <chuansheng.liu@intel.com>
Cc: vapier@gentoo.org
Cc: rusty@rustcorp.com.au
Link: http://lkml.kernel.org/r/4F75BED4.9050005@linux.vnet.ibm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 1f56ee7b

kernel/sched/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1268,7 +1268,7 @@ static int select_fallback_rq(int cpu, struct task_struct *p)
		int dest_cpu;

		/* Look for allowed, online CPU in same node. */
		for_each_cpu_mask(dest_cpu, *nodemask) {
		for_each_cpu(dest_cpu, nodemask) {
		if (!cpu_online(dest_cpu))
		continue;
		if (!cpu_active(dest_cpu))
		@@ -1279,7 +1279,7 @@ static int select_fallback_rq(int cpu, struct task_struct *p)

		for (;;) {
		/* Any allowed, online CPU? */
		for_each_cpu_mask(dest_cpu, *tsk_cpus_allowed(p)) {
		for_each_cpu(dest_cpu, tsk_cpus_allowed(p)) {
		if (!cpu_online(dest_cpu))
		continue;
		if (!cpu_active(dest_cpu))

Admin message