Unverified Commit e381bfe4 authored Oct 25, 2019 by Dmitry Osipenko Committed by Mark Brown Oct 28, 2019

regulator: core: Allow generic coupling only for always-on regulators

The generic voltage balancer doesn't work correctly if one of regulator
couples turns off. Currently there are no users in kernel for that case,
although let's explicitly show that this case is unsupported for those who
will try to use that feature.

Link: https://lore.kernel.org/linux-samsung-soc/20191008170503.yd6GscYPLxjgrXqDuCO7AJc6i6egNZGJkVWHLlCxvA4@z/

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20191025002240.25288-2-digetx@gmail.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 907becb2

drivers/regulator/core.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -4963,6 +4963,12 @@ static int generic_coupler_attach(struct regulator_coupler *coupler,
		return -EPERM;
		}

		if (!rdev->constraints->always_on) {
		rdev_err(rdev,
		"Coupling of a non always-on regulator is unimplemented\n");
		return -ENOTSUPP;
		}

		return 0;
		}