Commit e380ea81 authored May 09, 2019 by Jiada Wang Committed by Eduardo Valentin May 14, 2019

thermal: rcar_gen3_thermal: Fix to show correct trip points number



Currently after store trip points number in 'ret', it is overwritten
afterwards, this cause incorrect trip point number always be shown in
the debug information after register of each thermal zone.

This patch fix this issue by moving get of trip number to
end of thermal zone registration.

Fixes: 6269e9f7 ("thermal: rcar_gen3_thermal: Register hwmon sysfs interface")
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>

parent 20386f0d

drivers/thermal/rcar_gen3_thermal.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -410,10 +410,6 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
		}
		tsc->zone = zone;

		ret = of_thermal_get_ntrips(tsc->zone);
		if (ret < 0)
		goto error_unregister;

		tsc->zone->tzp->no_hwmon = false;
		ret = thermal_add_hwmon_sysfs(tsc->zone);
		if (ret)
		@@ -425,6 +421,10 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
		goto error_unregister;
		}

		ret = of_thermal_get_ntrips(tsc->zone);
		if (ret < 0)
		goto error_unregister;

		dev_info(dev, "TSC%d: Loaded %d trip points\n", i, ret);
		}

Admin message