Commit e37390be authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

cxlflash: a couple off by one bugs 



The "> MAX_CONTEXT" should be ">= MAX_CONTEXT".  Otherwise we go one
step beyond the end of the cfg->ctx_tbl[] array.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarManoj Kumar <manoj@linux.vnet.ibm.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Acked-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 23211c1e

drivers/scsi/cxlflash/superpipe.c

+2 −2
Original line number Diff line number Diff line
@@ -1380,7 +1380,7 @@ static int cxlflash_disk_attach(struct scsi_device *sdev, 
	}



	ctxid = cxl_process_element(ctx);

	if (unlikely((ctxid > MAX_CONTEXT) || (ctxid < 0))) {

	if (unlikely((ctxid >= MAX_CONTEXT) || (ctxid < 0))) {

		dev_err(dev, "%s: ctxid (%d) invalid!\n", __func__, ctxid);

		rc = -EPERM;

		goto err2;
@@ -1508,7 +1508,7 @@ static int recover_context(struct cxlflash_cfg *cfg, struct ctx_info *ctxi) 
	}



	ctxid = cxl_process_element(ctx);

	if (unlikely((ctxid > MAX_CONTEXT) || (ctxid < 0))) {

	if (unlikely((ctxid >= MAX_CONTEXT) || (ctxid < 0))) {

		dev_err(dev, "%s: ctxid (%d) invalid!\n", __func__, ctxid);

		rc = -EPERM;

		goto err1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE