Commit e365c3e7 authored Aug 23, 2007 by Ralf Baechle Committed by Greg Kroah-Hartman Sep 11, 2007

PCI: remove devinit from pci_read_bridge_bases



On MIPS with PCI && !HOTPLUG, I'm currently getting the following modpost
warning:

  MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x1ce128): Section mismatch: reference to .init.text:pci_read_bridge_bases (between 'pcibios_fixup_bus' and 'pcibios_enable_device')

On MIPS I have the call chains pci_scan_child_bus -> pcibios_fixup_bus ->
pci_read_bridge_bases.  pci_scan_child_bus can't be __devinit because it
it is an exported symbol, thus pcibios_fixup_bus and pci_read_bridge_bases
can't be either.

For some reason I don't see this issue on x86; I blame compiler differences.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 5547bbee

drivers/pci/probe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -285,7 +285,7 @@ static void pci_read_bases(struct pci_dev *dev, unsigned int howmany, int rom)
		}
		}

		void __devinit pci_read_bridge_bases(struct pci_bus *child)
		void pci_read_bridge_bases(struct pci_bus *child)
		{
		struct pci_dev *dev = child->self;
		u8 io_base_lo, io_limit_lo;

Admin message