Commit e34a314c authored by Dave Chinner's avatar Dave Chinner Committed by Alex Elder
Browse files

xfs: fix efi item leak on forced shutdown 



After test 139, kmemleak shows:

unreferenced object 0xffff880078b405d8 (size 400):
  comm "xfs_io", pid 4904, jiffies 4294909383 (age 1186.728s)
  hex dump (first 32 bytes):
    60 c1 17 79 00 88 ff ff 60 c1 17 79 00 88 ff ff  `..y....`..y....
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60
    [<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0
    [<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0
    [<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50
    [<ffffffff8147cd6b>] xfs_efi_init+0x4b/0xb0
    [<ffffffff814a4ee8>] xfs_trans_get_efi+0x58/0x90
    [<ffffffff81455fab>] xfs_bmap_finish+0x8b/0x1d0
    [<ffffffff814851b4>] xfs_itruncate_finish+0x2c4/0x5d0
    [<ffffffff814a970f>] xfs_setattr+0x8df/0xa70
    [<ffffffff814b5c7b>] xfs_vn_setattr+0x1b/0x20
    [<ffffffff8117dc00>] notify_change+0x170/0x2e0
    [<ffffffff81163bf6>] do_truncate+0x66/0xa0
    [<ffffffff81163d0b>] sys_ftruncate+0xdb/0xe0
    [<ffffffff8103a002>] system_call_fastpath+0x16/0x1b
    [<ffffffffffffffff>] 0xffffffffffffffff

The cause of the leak is that the "remove" parameter of IOP_UNPIN()
is never set when a CIL push is aborted. This means that the EFI
item is never freed if it was in the push being cancelled. The
problem is specific to delayed logging, but has uncovered a couple
of problems with the handling of IOP_UNPIN(remove).

Firstly, we cannot safely call xfs_trans_del_item() from IOP_UNPIN()
in the CIL commit failure path or the iclog write failure path
because for delayed loging we have no transaction context. Hence we
must only call xfs_trans_del_item() if the log item being unpinned
has an active log item descriptor.

Secondly, xfs_trans_uncommit() does not handle log item descriptor
freeing during the traversal of log items on a transaction. It can
reference a freed log item descriptor when unpinning an EFI item.
Hence it needs to use a safe list traversal method to allow items to
be removed from the transaction during IOP_UNPIN().

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarAlex Elder <aelder@sgi.com>
parent 7db37c5e

fs/xfs/xfs_buf_item.c

+7 −5
Original line number Diff line number Diff line
@@ -427,12 +427,14 @@ xfs_buf_item_unpin( 


		if (remove) {

			/*

			 * We have to remove the log item from the transaction

			 * as we are about to release our reference to the

			 * buffer.  If we don't, the unlock that occurs later

			 * in xfs_trans_uncommit() will ry to reference the

			 * If we are in a transaction context, we have to

			 * remove the log item from the transaction as we are

			 * about to release our reference to the buffer.  If we

			 * don't, the unlock that occurs later in

			 * xfs_trans_uncommit() will try to reference the

			 * buffer which we no longer have a hold on.

			 */

			if (lip->li_desc)

				xfs_trans_del_item(lip);



			/*

fs/xfs/xfs_extfree_item.c

+2 −1
Original line number Diff line number Diff line
@@ -138,6 +138,7 @@ xfs_efi_item_unpin( 


	if (remove) {

		ASSERT(!(lip->li_flags & XFS_LI_IN_AIL));

		if (lip->li_desc)

			xfs_trans_del_item(lip);

		xfs_efi_item_free(efip);

		return;

fs/xfs/xfs_trans.c

+29 −7
Original line number Diff line number Diff line
@@ -1446,6 +1446,14 @@ xfs_log_item_batch_insert( 
 * Bulk operation version of xfs_trans_committed that takes a log vector of

 * items to insert into the AIL. This uses bulk AIL insertion techniques to

 * minimise lock traffic.

 *

 * If we are called with the aborted flag set, it is because a log write during

 * a CIL checkpoint commit has failed. In this case, all the items in the

 * checkpoint have already gone through IOP_COMMITED and IOP_UNLOCK, which

 * means that checkpoint commit abort handling is treated exactly the same

 * as an iclog write error even though we haven't started any IO yet. Hence in

 * this case all we need to do is IOP_COMMITTED processing, followed by an

 * IOP_UNPIN(aborted) call.

 */

void

xfs_trans_committed_bulk(
@@ -1472,6 +1480,16 @@ xfs_trans_committed_bulk( 
		if (XFS_LSN_CMP(item_lsn, (xfs_lsn_t)-1) == 0)

			continue;



		/*

		 * if we are aborting the operation, no point in inserting the

		 * object into the AIL as we are in a shutdown situation.

		 */

		if (aborted) {

			ASSERT(XFS_FORCED_SHUTDOWN(ailp->xa_mount));

			IOP_UNPIN(lip, 1);

			continue;

		}



		if (item_lsn != commit_lsn) {



			/*
@@ -1503,20 +1521,24 @@ xfs_trans_committed_bulk( 
}



/*

 * Called from the trans_commit code when we notice that

 * the filesystem is in the middle of a forced shutdown.

 * Called from the trans_commit code when we notice that the filesystem is in

 * the middle of a forced shutdown.

 *

 * When we are called here, we have already pinned all the items in the

 * transaction. However, neither IOP_COMMITTING or IOP_UNLOCK has been called

 * so we can simply walk the items in the transaction, unpin them with an abort

 * flag and then free the items. Note that unpinning the items can result in

 * them being freed immediately, so we need to use a safe list traversal method

 * here.

 */

STATIC void

xfs_trans_uncommit(

	struct xfs_trans	*tp,

	uint			flags)

{

	struct xfs_log_item_desc *lidp;

	struct xfs_log_item_desc *lidp, *n;



	list_for_each_entry(lidp, &tp->t_items, lid_trans) {

		/*

		 * Unpin all but those that aren't dirty.

		 */

	list_for_each_entry_safe(lidp, n, &tp->t_items, lid_trans) {

		if (lidp->lid_flags & XFS_LID_DIRTY)

			IOP_UNPIN(lidp->lid_item, 1);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE