Commit e3448967 authored Apr 03, 2019 by Gustavo A. R. Silva Committed by Luca Coelho Jun 29, 2019

iwlwifi: d3: Use struct_size() helper



Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, change the following form:

sizeof(*pattern_cmd) +
               wowlan->n_patterns * sizeof(struct iwlagn_wowlan_pattern)

 to :

struct_size(pattern_cmd, patterns, wowlan->n_patterns)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 8283f4f8

drivers/net/wireless/intel/iwlwifi/mvm/d3.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -398,8 +398,7 @@ static int iwl_mvm_send_patterns_v1(struct iwl_mvm *mvm,
		if (!wowlan->n_patterns)
		return 0;

		cmd.len[0] = sizeof(*pattern_cmd) +
		wowlan->n_patterns * sizeof(struct iwl_wowlan_pattern_v1);
		cmd.len[0] = struct_size(pattern_cmd, patterns, wowlan->n_patterns);

		pattern_cmd = kmalloc(cmd.len[0], GFP_KERNEL);
		if (!pattern_cmd)

Admin message