Commit e33d085d authored Jun 09, 2013 by dan.carpenter@oracle.com Committed by Mark Brown Jun 10, 2013

spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()



'!' has higher precedence than comparisons so the original condition
is equivalent to "if (xspi->remaining_bytes == 0)".  This makes the
static checkers complain.

xspi->remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative.  I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 68c315bb

drivers/spi/spi-xilinx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -315,7 +315,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device spi, struct spi_transfer t)
		}

		/* See if there is more data to send */
		if (!xspi->remaining_bytes > 0)
		if (xspi->remaining_bytes <= 0)
		break;
		}

Admin message