Commit e3297803 authored Apr 23, 2014 by Tejun Heo

cgroup: cgroup->subsys[] should be cleared after the css is offlined



After a css finishes offlining, offline_css() mistakenly performs
RCU_INIT_POINTER(css->cgroup->subsys[ss->id], css) which just sets the
cgroup->subsys[] pointer to the current value.  The intention was to
clear it after offline is complete, not reassign the same value.

Update it to assign NULL instead of the current value.  This makes
cgroup_css() to return NULL once offline is complete.  All the
existing users of the function either can handle NULL return already
or guarantee that the css doesn't get offlined.

While this is a bugfix, as css lifetime is currently tied to the
cgroup it belongs to, this bug doesn't cause any actual problems.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>

parent 3ebb2b6e

kernel/cgroup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3710,7 +3710,7 @@ static void offline_css(struct cgroup_subsys_state *css)

		css->flags &= ~CSS_ONLINE;
		css->cgroup->nr_css--;
		RCU_INIT_POINTER(css->cgroup->subsys[ss->id], css);
		RCU_INIT_POINTER(css->cgroup->subsys[ss->id], NULL);
		}

		/**

Admin message