ALSA: pcxhr.h replace signed one-bit bitfields (e32740d9) · Commits · 戴 / test

The usage and comments make it clear values of 1/0 were intended rather than -1/0 Noticed by sparse: sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfield Signed-off-by:

Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/pci/pcxhr/pcxhr.h

+6 −6

Original line number	Diff line number	Diff line
		@@ -97,12 +97,12 @@ struct pcxhr_mgr {
		int capture_chips;
		int fw_file_set;
		int firmware_num;
		int is_hr_stereo:1;
		int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */
		int board_has_analog:1; /* if 0 the board is digital only */
		int board_has_mic:1; /* if 1 the board has microphone input */
		int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
		int mono_capture:1; /* if 1 the board does mono capture */
		unsigned int is_hr_stereo:1;
		unsigned int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */
		unsigned int board_has_analog:1; /* if 0 the board is digital only */
		unsigned int board_has_mic:1; /* if 1 the board has microphone input */
		unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
		unsigned int mono_capture:1; /* if 1 the board does mono capture */

		struct snd_dma_buffer hostport;

Admin message