Commit e2f608be authored Jun 18, 2016 by Linus Walleij

gpio: make the iterator point to last handle



When initializing the GPIO handles, we use the iterator (i)
to back off if something goes wrong. But since the iterator
is also used after we pass the loop, we must decrement by
one after exiting the loop so that we point at the last
element in the array.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Walter Harms <wharms@bfs.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent bc0207a5

drivers/gpio/gpiolib.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -474,6 +474,8 @@ static int linehandle_create(struct gpio_device gdev, void __user ip)
		dev_dbg(&gdev->dev, "registered chardev handle for line %d\n",
		offset);
		}
		/* Let i point at the last handle */
		i--;
		lh->numdescs = handlereq.lines;

		fd = anon_inode_getfd("gpio-linehandle",

Admin message