Commit e2ed89fc authored Apr 13, 2012 by Paul Walmsley

ARM: OMAP: add includes for missing prototypes

Several C files in arch/arm/mach-omap* and arch/arm/plat-omap declare
functions that are used by other files, but don't include the header
file where the prototype is declared. This results in the following
warnings from sparse:

arch/arm/mach-omap2/irq.c:114:5: warning: symbol 'omap_irq_pending' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:186:13: warning: symbol 'omap2_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:191:13: warning: symbol 'omap3_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:196:13: warning: symbol 'ti81xx_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:233:39: warning: symbol 'omap2_intc_handle_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:242:6: warning: symbol 'omap_intc_save_context' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:265:6: warning: symbol 'omap_intc_restore_context' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:291:6: warning: symbol 'omap3_intc_suspend' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:297:6: warning: symbol 'omap3_intc_prepare_idle' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:306:6: warning: symbol 'omap3_intc_resume_idle' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:312:39: warning: symbol 'omap3_intc_handle_irq' was not declared. Should it be static?
arch/arm/mach-omap2/omap-secure.c:59:12: warning: symbol 'omap_secure_ram_reserve_memblock' was not declared. Should it be static?
arch/arm/mach-omap2/board-zoom-display.c:133:13: warning: symbol 'zoom_display_init' was not declared. Should it be static?
arch/arm/plat-omap/common.c:73:13: warning: symbol 'omap_init_consistent_dma_size' was not declared. Should it be static?
arch/arm/mach-omap1/irq.c:61:5: warning: symbol 'omap_irq_flags' was not declared. Should it be static?
arch/arm/mach-omap1/irq.c:179:13: warning: symbol 'omap1_init_irq' was not declared. Should it be static?
arch/arm/mach-omap1/reset.c:11:6: warning: symbol 'omap1_restart' was not declared. Should it be static?

Fix by including the appropriate header files.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

parent 8c3d4534

arch/arm/mach-omap1/common.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -56,8 +56,11 @@ void omap1_init_early(void);
		void omap1_init_irq(void);
		void omap1_restart(char, const char *);

		extern void __init omap_check_revision(void);

		extern struct sys_timer omap1_timer;
		extern bool omap_32k_timer_init(void);
		extern void __init omap_init_consistent_dma_size(void);

		extern u32 omap_irq_flags;

		#endif /* __ARCH_ARM_MACH_OMAP1_COMMON_H */

arch/arm/mach-omap1/id.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -21,6 +21,8 @@

		#include <mach/hardware.h>

		#include "common.h"

		#define OMAP_DIE_ID_0 0xfffe1800
		#define OMAP_DIE_ID_1 0xfffe1804
		#define OMAP_PRODUCTION_ID_0 0xfffe2000

arch/arm/mach-omap1/io.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -18,13 +18,12 @@

		#include <plat/mux.h>
		#include <plat/tc.h>
		#include <plat/dma.h>

		#include "iomap.h"
		#include "common.h"
		#include "clock.h"

		extern void omap_check_revision(void);

		/*
		* The machine specific code may provide the extra mapping besides the
		* default mapping provided here.

arch/arm/mach-omap1/irq.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -49,6 +49,8 @@

		#include <mach/hardware.h>

		#include "common.h"

		#define IRQ_BANK(irq) ((irq) >> 5)
		#define IRQ_BIT(irq) ((irq) & 0x1f)

arch/arm/mach-omap1/reset.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -8,6 +8,8 @@

		#include <mach/hardware.h>

		#include "common.h"

		void omap1_restart(char mode, const char *cmd)
		{
		/*

Admin message