Commit e2debf08 authored Feb 11, 2020 by Davide Caratti Committed by David S. Miller Feb 13, 2020

net/sched: flower: add missing validation of TCA_FLOWER_FLAGS



unlike other classifiers that can be offloaded (i.e. users can set flags
like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of
netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry
to fl_policy.

Fixes: 5b33f488 ("net/flower: Introduce hardware offload support")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1afa3cc9

net/sched/cls_flower.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -691,6 +691,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = {
		.len = 128 / BITS_PER_BYTE },
		[TCA_FLOWER_KEY_CT_LABELS_MASK] = { .type = NLA_BINARY,
		.len = 128 / BITS_PER_BYTE },
		[TCA_FLOWER_FLAGS] = { .type = NLA_U32 },
		};

		static const struct nla_policy

Admin message