phy: ti: j721e-wiz: Fix some error return code in wiz_probe() (e2ae8bca) · Commits · 戴 / test

Fix to return negative error code from some error handling cases instead of 0, as done elsewhere in this function. Fixes: ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Wei Yongjun <weiyongjun1@huawei.com> Acked-by:

Roger Quadros <rogerq@ti.com> Link: https://lore.kernel.org/r/20200507054109.110849-1-weiyongjun1@huawei.com Signed-off-by:

Kishon Vijay Abraham I <kishon@ti.com>

drivers/phy/ti/phy-j721e-wiz.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -841,8 +841,10 @@ static int wiz_probe(struct platform_device *pdev)
		}

		base = devm_ioremap(dev, res.start, resource_size(&res));
		if (!base)
		if (!base) {
		ret = -ENOMEM;
		goto err_addr_to_resource;
		}

		regmap = devm_regmap_init_mmio(dev, base, &wiz_regmap_config);
		if (IS_ERR(regmap)) {
		@@ -859,6 +861,7 @@ static int wiz_probe(struct platform_device *pdev)

		if (num_lanes > WIZ_MAX_LANES) {
		dev_err(dev, "Cannot support %d lanes\n", num_lanes);
		ret = -ENODEV;
		goto err_addr_to_resource;
		}

		@@ -948,6 +951,7 @@ static int wiz_probe(struct platform_device *pdev)
		serdes_pdev = of_platform_device_create(child_node, NULL, dev);
		if (!serdes_pdev) {
		dev_WARN(dev, "Unable to create SERDES platform device\n");
		ret = -ENOMEM;
		goto err_pdev_create;
		}
		wiz->serdes_pdev = serdes_pdev;

Admin message