Commit e2a71bde authored Jul 17, 2020 by Frederic Weisbecker Committed by Thomas Gleixner Jul 17, 2020

timer: Fix wheel index calculation on last level



When an expiration delta falls into the last level of the wheel, that delta
has be compared against the maximum possible delay and reduced to fit in if
necessary.

However instead of comparing the delta against the maximum, the code
compares the actual expiry against the maximum. Then instead of fixing the
delta to fit in, it sets the maximum delta as the expiry value.

This can result in various undesired outcomes, the worst possible one
being a timer expiring 15 days ahead to fire immediately.

Fixes: 500462a9 ("timers: Switch to a non-cascading wheel")
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20200717140551.29076-2-frederic@kernel.org

parent 30c66fc3

kernel/time/timer.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -521,8 +521,8 @@ static int calc_wheel_index(unsigned long expires, unsigned long clk)
		* Force expire obscene large timeouts to expire at the
		* capacity limit of the wheel.
		*/
		if (expires >= WHEEL_TIMEOUT_CUTOFF)
		expires = WHEEL_TIMEOUT_MAX;
		if (delta >= WHEEL_TIMEOUT_CUTOFF)
		expires = clk + WHEEL_TIMEOUT_MAX;

		idx = calc_index(expires, LVL_DEPTH - 1);
		}

Admin message