Commit e2a2e56e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Catalin Marinas
Browse files

arm64: dump: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Will Deacon <will.deacon@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Peng Donglin <dolinux.peng@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 0bd3ef34

arch/arm64/include/asm/ptdump.h

+3 −6
Original line number Diff line number Diff line
@@ -34,13 +34,10 @@ struct ptdump_info { 


void ptdump_walk_pgd(struct seq_file *s, struct ptdump_info *info);

#ifdef CONFIG_ARM64_PTDUMP_DEBUGFS

int ptdump_debugfs_register(struct ptdump_info *info, const char *name);

void ptdump_debugfs_register(struct ptdump_info *info, const char *name);

#else

static inline int ptdump_debugfs_register(struct ptdump_info *info,

					const char *name)

{

	return 0;

}

static inline void ptdump_debugfs_register(struct ptdump_info *info,

					   const char *name) { }

#endif

void ptdump_check_wx(void);

#endif /* CONFIG_ARM64_PTDUMP_CORE */

arch/arm64/mm/dump.c

+2 −2
Original line number Diff line number Diff line
@@ -407,7 +407,7 @@ void ptdump_check_wx(void) 
static int ptdump_init(void)

{

	ptdump_initialize();

	return ptdump_debugfs_register(&kernel_ptdump_info,

					"kernel_page_tables");

	ptdump_debugfs_register(&kernel_ptdump_info, "kernel_page_tables");

	return 0;

}

device_initcall(ptdump_init);

arch/arm64/mm/ptdump_debugfs.c

+2 −5
Original line number Diff line number Diff line
@@ -12,10 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v) 
}

DEFINE_SHOW_ATTRIBUTE(ptdump);



int ptdump_debugfs_register(struct ptdump_info *info, const char *name)

void ptdump_debugfs_register(struct ptdump_info *info, const char *name)

{

	struct dentry *pe;

	pe = debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);

	return pe ? 0 : -ENOMEM;



	debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE