ubifs: mount_ubifs: Release authentication resource in error handling path (e2a05cc7) · Commits · 戴 / test

Release the authentication related resource in some error handling branches in mount_ubifs(). Signed-off-by:

Zhihao Cheng <chengzhihao1@huawei.com> Cc: <stable@vger.kernel.org> # 4.20+ Fixes: ("ubifs: Enable authentication support") Reviewed-by:

fs/ubifs/super.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -1331,7 +1331,7 @@ static int mount_ubifs(struct ubifs_info *c)

		err = ubifs_read_superblock(c);
		if (err)
		goto out_free;
		goto out_auth;

		c->probing = 0;

		@@ -1343,18 +1343,18 @@ static int mount_ubifs(struct ubifs_info *c)
		ubifs_err(c, "'compressor \"%s\" is not compiled in",
		ubifs_compr_name(c, c->default_compr));
		err = -ENOTSUPP;
		goto out_free;
		goto out_auth;
		}

		err = init_constants_sb(c);
		if (err)
		goto out_free;
		goto out_auth;

		sz = ALIGN(c->max_idx_node_sz, c->min_io_size) * 2;
		c->cbuf = kmalloc(sz, GFP_NOFS);
		if (!c->cbuf) {
		err = -ENOMEM;
		goto out_free;
		goto out_auth;
		}

		err = alloc_wbufs(c);
		@@ -1629,6 +1629,8 @@ out_wbufs:
		free_wbufs(c);
		out_cbuf:
		kfree(c->cbuf);
		out_auth:
		ubifs_exit_authentication(c);
		out_free:
		kfree(c->write_reserve_buf);
		kfree(c->bu.buf);