Commit e298c499 authored May 02, 2016 by Anna-Maria Gleixner Committed by Tony Luck May 02, 2016

ia64: Remove superfluous SMP function call



Since commit 3b9d6da6 ("cpu/hotplug: Fix rollback during error-out
in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
ia64_mca_cmc_vector_adjust(). The function itselfs handles disable and
enable interrupts, therefore the smp_call_function_single() calling
convention is not preserved.

Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent 04974df8

arch/ia64/kernel/mca.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1904,13 +1904,10 @@ static int mca_cpu_callback(struct notifier_block *nfb,
		unsigned long action,
		void *hcpu)
		{
		int hotcpu = (unsigned long) hcpu;

		switch (action) {
		case CPU_ONLINE:
		case CPU_ONLINE_FROZEN:
		smp_call_function_single(hotcpu, ia64_mca_cmc_vector_adjust,
		NULL, 0);
		ia64_mca_cmc_vector_adjust(NULL);
		break;
		}
		return NOTIFY_OK;

Admin message