Commit e27be240 authored by Johannes Weiner's avatar Johannes Weiner Committed by Linus Torvalds
Browse files

mm: memcg: make sure memory.events is uptodate when waking pollers 

Commit a983b5eb ("mm: memcontrol: fix excessive complexity in
memory.stat reporting") added per-cpu drift to all memory cgroup stats
and events shown in memory.stat and memory.events.

For memory.stat this is acceptable.  But memory.events issues file
notifications, and somebody polling the file for changes will be
confused when the counters in it are unchanged after a wakeup.

Luckily, the events in memory.events - MEMCG_LOW, MEMCG_HIGH, MEMCG_MAX,
MEMCG_OOM - are sufficiently rare and high-level that we don't need
per-cpu buffering for them: MEMCG_HIGH and MEMCG_MAX would be the most
frequent, but they're counting invocations of reclaim, which is a
complex operation that touches many shared cachelines.

This splits memory.events from the generic VM events and tracks them in
their own, unbuffered atomic counters.  That's also cleaner, as it
eliminates the ugly enum nesting of VM and cgroup events.

[hannes@cmpxchg.org: "array subscript is above array bounds"]
  Link: http://lkml.kernel.org/r/20180406155441.GA20806@cmpxchg.org
Link: http://lkml.kernel.org/r/20180405175507.GA24817@cmpxchg.org


Fixes: a983b5eb ("mm: memcontrol: fix excessive complexity in memory.stat reporting")
Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Reported-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Roman Gushchin <guro@fb.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a38c015f

include/linux/memcontrol.h

+18 −17
Original line number Diff line number Diff line
@@ -48,13 +48,12 @@ enum memcg_stat_item { 
	MEMCG_NR_STAT,

};



/* Cgroup-specific events, on top of universal VM events */

enum memcg_event_item {

	MEMCG_LOW = NR_VM_EVENT_ITEMS,

enum memcg_memory_event {

	MEMCG_LOW,

	MEMCG_HIGH,

	MEMCG_MAX,

	MEMCG_OOM,

	MEMCG_NR_EVENTS,

	MEMCG_NR_MEMORY_EVENTS,

};



struct mem_cgroup_reclaim_cookie {
@@ -88,7 +87,7 @@ enum mem_cgroup_events_target { 


struct mem_cgroup_stat_cpu {

	long count[MEMCG_NR_STAT];

	unsigned long events[MEMCG_NR_EVENTS];

	unsigned long events[NR_VM_EVENT_ITEMS];

	unsigned long nr_page_events;

	unsigned long targets[MEM_CGROUP_NTARGETS];

};
@@ -205,7 +204,8 @@ struct mem_cgroup { 
	/* OOM-Killer disable */

	int		oom_kill_disable;



	/* handle for "memory.events" */

	/* memory.events */

	atomic_long_t memory_events[MEMCG_NR_MEMORY_EVENTS];

	struct cgroup_file events_file;



	/* protect arrays of thresholds */
@@ -234,9 +234,10 @@ struct mem_cgroup { 
	struct task_struct	*move_lock_task;

	unsigned long		move_lock_flags;



	/* memory.stat */

	struct mem_cgroup_stat_cpu __percpu *stat_cpu;

	atomic_long_t		stat[MEMCG_NR_STAT];

	atomic_long_t		events[MEMCG_NR_EVENTS];

	atomic_long_t		events[NR_VM_EVENT_ITEMS];



	unsigned long		socket_pressure;
@@ -648,9 +649,9 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, 
						gfp_t gfp_mask,

						unsigned long *total_scanned);



/* idx can be of type enum memcg_event_item or vm_event_item */

static inline void __count_memcg_events(struct mem_cgroup *memcg,

					int idx, unsigned long count)

					enum vm_event_item idx,

					unsigned long count)

{

	unsigned long x;
@@ -666,7 +667,8 @@ static inline void __count_memcg_events(struct mem_cgroup *memcg, 
}



static inline void count_memcg_events(struct mem_cgroup *memcg,

				      int idx, unsigned long count)

				      enum vm_event_item idx,

				      unsigned long count)

{

	unsigned long flags;
@@ -675,9 +677,8 @@ static inline void count_memcg_events(struct mem_cgroup *memcg, 
	local_irq_restore(flags);

}



/* idx can be of type enum memcg_event_item or vm_event_item */

static inline void count_memcg_page_event(struct page *page,

					  int idx)

					  enum vm_event_item idx)

{

	if (page->mem_cgroup)

		count_memcg_events(page->mem_cgroup, idx, 1);
@@ -701,10 +702,10 @@ static inline void count_memcg_event_mm(struct mm_struct *mm, 
	rcu_read_unlock();

}



static inline void mem_cgroup_event(struct mem_cgroup *memcg,

				    enum memcg_event_item event)

static inline void memcg_memory_event(struct mem_cgroup *memcg,

				      enum memcg_memory_event event)

{

	count_memcg_events(memcg, event, 1);

	atomic_long_inc(&memcg->memory_events[event]);

	cgroup_file_notify(&memcg->events_file);

}
@@ -724,8 +725,8 @@ static inline bool mem_cgroup_disabled(void) 
	return true;

}



static inline void mem_cgroup_event(struct mem_cgroup *memcg,

				    enum memcg_event_item event)

static inline void memcg_memory_event(struct mem_cgroup *memcg,

				      enum memcg_memory_event event)

{

}

mm/memcontrol.c

+16 −12
Original line number Diff line number Diff line
@@ -1839,7 +1839,7 @@ static int memcg_hotplug_cpu_dead(unsigned int cpu) 
			}

		}



		for (i = 0; i < MEMCG_NR_EVENTS; i++) {

		for (i = 0; i < NR_VM_EVENT_ITEMS; i++) {

			long x;



			x = this_cpu_xchg(memcg->stat_cpu->events[i], 0);
@@ -1858,7 +1858,7 @@ static void reclaim_high(struct mem_cgroup *memcg, 
	do {

		if (page_counter_read(&memcg->memory) <= memcg->high)

			continue;

		mem_cgroup_event(memcg, MEMCG_HIGH);

		memcg_memory_event(memcg, MEMCG_HIGH);

		try_to_free_mem_cgroup_pages(memcg, nr_pages, gfp_mask, true);

	} while ((memcg = parent_mem_cgroup(memcg)));

}
@@ -1949,7 +1949,7 @@ retry: 
	if (!gfpflags_allow_blocking(gfp_mask))

		goto nomem;



	mem_cgroup_event(mem_over_limit, MEMCG_MAX);

	memcg_memory_event(mem_over_limit, MEMCG_MAX);



	nr_reclaimed = try_to_free_mem_cgroup_pages(mem_over_limit, nr_pages,

						    gfp_mask, may_swap);
@@ -1992,7 +1992,7 @@ retry: 
	if (fatal_signal_pending(current))

		goto force;



	mem_cgroup_event(mem_over_limit, MEMCG_OOM);

	memcg_memory_event(mem_over_limit, MEMCG_OOM);



	mem_cgroup_oom(mem_over_limit, gfp_mask,

		       get_order(nr_pages * PAGE_SIZE));
@@ -2688,10 +2688,10 @@ static void tree_events(struct mem_cgroup *memcg, unsigned long *events) 
	struct mem_cgroup *iter;

	int i;



	memset(events, 0, sizeof(*events) * MEMCG_NR_EVENTS);

	memset(events, 0, sizeof(*events) * NR_VM_EVENT_ITEMS);



	for_each_mem_cgroup_tree(iter, memcg) {

		for (i = 0; i < MEMCG_NR_EVENTS; i++)

		for (i = 0; i < NR_VM_EVENT_ITEMS; i++)

			events[i] += memcg_sum_events(iter, i);

	}

}
@@ -5178,7 +5178,7 @@ static ssize_t memory_max_write(struct kernfs_open_file *of, 
			continue;

		}



		mem_cgroup_event(memcg, MEMCG_OOM);

		memcg_memory_event(memcg, MEMCG_OOM);

		if (!mem_cgroup_out_of_memory(memcg, GFP_KERNEL, 0))

			break;

	}
@@ -5191,10 +5191,14 @@ static int memory_events_show(struct seq_file *m, void *v) 
{

	struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m));



	seq_printf(m, "low %lu\n", memcg_sum_events(memcg, MEMCG_LOW));

	seq_printf(m, "high %lu\n", memcg_sum_events(memcg, MEMCG_HIGH));

	seq_printf(m, "max %lu\n", memcg_sum_events(memcg, MEMCG_MAX));

	seq_printf(m, "oom %lu\n", memcg_sum_events(memcg, MEMCG_OOM));

	seq_printf(m, "low %lu\n",

		   atomic_long_read(&memcg->memory_events[MEMCG_LOW]));

	seq_printf(m, "high %lu\n",

		   atomic_long_read(&memcg->memory_events[MEMCG_HIGH]));

	seq_printf(m, "max %lu\n",

		   atomic_long_read(&memcg->memory_events[MEMCG_MAX]));

	seq_printf(m, "oom %lu\n",

		   atomic_long_read(&memcg->memory_events[MEMCG_OOM]));

	seq_printf(m, "oom_kill %lu\n", memcg_sum_events(memcg, OOM_KILL));



	return 0;
@@ -5204,7 +5208,7 @@ static int memory_stat_show(struct seq_file *m, void *v) 
{

	struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m));

	unsigned long stat[MEMCG_NR_STAT];

	unsigned long events[MEMCG_NR_EVENTS];

	unsigned long events[NR_VM_EVENT_ITEMS];

	int i;



	/*

mm/vmscan.c

+1 −1
Original line number Diff line number Diff line
@@ -2530,7 +2530,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) 
					sc->memcg_low_skipped = 1;

					continue;

				}

				mem_cgroup_event(memcg, MEMCG_LOW);

				memcg_memory_event(memcg, MEMCG_LOW);

			}



			reclaimed = sc->nr_reclaimed;

CRA Git | Maintained and supported by SUSTech CRA and CCSE