PCI: Remove unused alloc_pci_dev() (e2760c54) · Commits · 戴 / test

My philosophy is unused code is dead code. And dead code is subject to bit rot and is a likely source of bugs. Use it or lose it. This removes this unused and deprecated interface: alloc_pci_dev() [bhelgaas: split to separate patch] Signed-off-by:

Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com>

drivers/pci/probe.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1242,12 +1242,6 @@ struct pci_dev pci_alloc_dev(struct pci_bus bus)
		}
		EXPORT_SYMBOL(pci_alloc_dev);

		struct pci_dev *alloc_pci_dev(void)
		{
		return pci_alloc_dev(NULL);
		}
		EXPORT_SYMBOL(alloc_pci_dev);

		bool pci_bus_read_dev_vendor_id(struct pci_bus bus, int devfn, u32 l,
		int crs_timeout)
		{

include/linux/pci.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -375,7 +375,6 @@ static inline struct pci_dev pci_physfn(struct pci_dev dev)
		}

		struct pci_dev pci_alloc_dev(struct pci_bus bus);
		struct pci_dev * __deprecated alloc_pci_dev(void);

		#define to_pci_dev(n) container_of(n, struct pci_dev, dev)
		#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)

Admin message