Commit e275d210 authored by Tony Lindgren's avatar Tony Lindgren
Browse files

bus: ti-sysc: Fix reset status check for modules with quirks 



Commit d46f9fbe ("bus: ti-sysc: Use optional clocks on for enable and
wait for softreset bit") started showing a "OCP softreset timed out"
warning on enable if the interconnect target module is not out of reset.
This caused the warning to be often triggered for i2c and hdq while the
devices are working properly.

Turns out that some interconnect target modules seem to have an unusable
reset status bits unless the module specific reset quirks are activated.

Let's just skip the reset status check for those modules as we only want
to activate the reset quirks when doing a reset, and not on enable. This
way we don't see the bogus "OCP softreset timed out" warnings during boot.

Fixes: d46f9fbe ("bus: ti-sysc: Use optional clocks on for enable and wait for softreset bit")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent b69fd001

drivers/bus/ti-sysc.c

+15 −9
Original line number Diff line number Diff line
@@ -970,9 +970,15 @@ static int sysc_enable_module(struct device *dev) 
			return error;

		}

	}

	/*

	 * Some modules like i2c and hdq1w have unusable reset status unless

	 * the module reset quirk is enabled. Skip status check on enable.

	 */

	if (!(ddata->cfg.quirks & SYSC_MODULE_QUIRK_ENA_RESETDONE)) {

		error = sysc_wait_softreset(ddata);

		if (error)

			dev_warn(ddata->dev, "OCP softreset timed out\n");

	}

	if (ddata->cfg.quirks & SYSC_QUIRK_OPT_CLKS_IN_RESET)

		sysc_disable_opt_clocks(ddata);
@@ -1373,17 +1379,17 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { 
	SYSC_QUIRK("hdmi", 0, 0, 0x10, -ENODEV, 0x50030200, 0xffffffff,

		   SYSC_QUIRK_OPT_CLKS_NEEDED),

	SYSC_QUIRK("hdq1w", 0, 0, 0x14, 0x18, 0x00000006, 0xffffffff,

		   SYSC_MODULE_QUIRK_HDQ1W),

		   SYSC_MODULE_QUIRK_HDQ1W | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("hdq1w", 0, 0, 0x14, 0x18, 0x0000000a, 0xffffffff,

		   SYSC_MODULE_QUIRK_HDQ1W),

		   SYSC_MODULE_QUIRK_HDQ1W | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("i2c", 0, 0, 0x20, 0x10, 0x00000036, 0x000000ff,

		   SYSC_MODULE_QUIRK_I2C),

		   SYSC_MODULE_QUIRK_I2C | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("i2c", 0, 0, 0x20, 0x10, 0x0000003c, 0x000000ff,

		   SYSC_MODULE_QUIRK_I2C),

		   SYSC_MODULE_QUIRK_I2C | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("i2c", 0, 0, 0x20, 0x10, 0x00000040, 0x000000ff,

		   SYSC_MODULE_QUIRK_I2C),

		   SYSC_MODULE_QUIRK_I2C | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("i2c", 0, 0, 0x10, 0x90, 0x5040000a, 0xfffff0f0,

		   SYSC_MODULE_QUIRK_I2C),

		   SYSC_MODULE_QUIRK_I2C | SYSC_MODULE_QUIRK_ENA_RESETDONE),

	SYSC_QUIRK("gpu", 0x50000000, 0x14, -ENODEV, -ENODEV, 0x00010201, 0xffffffff, 0),

	SYSC_QUIRK("gpu", 0x50000000, 0xfe00, 0xfe10, -ENODEV, 0x40000000 , 0xffffffff,

		   SYSC_MODULE_QUIRK_SGX),

include/linux/platform_data/ti-sysc.h

+1 −0
Original line number Diff line number Diff line
@@ -50,6 +50,7 @@ struct sysc_regbits { 
	s8 emufree_shift;

};



#define SYSC_MODULE_QUIRK_ENA_RESETDONE	BIT(25)

#define SYSC_MODULE_QUIRK_PRUSS		BIT(24)

#define SYSC_MODULE_QUIRK_DSS_RESET	BIT(23)

#define SYSC_MODULE_QUIRK_RTC_UNLOCK	BIT(22)

CRA Git | Maintained and supported by SUSTech CRA and CCSE