Commit e26cc082 authored Aug 12, 2019 by zhengbin Committed by Jens Axboe Aug 12, 2019

blk-mq: move cancel of requeue_work to the front of blk_exit_queue



blk_exit_queue will free elevator_data, while blk_mq_requeue_work
will access it. Move cancel of requeue_work to the front of
blk_exit_queue to avoid use-after-free.

blk_exit_queue                blk_mq_requeue_work
  __elevator_exit               blk_mq_run_hw_queues
    blk_mq_exit_sched             blk_mq_run_hw_queue
      dd_exit_queue                 blk_mq_hctx_has_pending
        kfree(elevator_data)          blk_mq_sched_has_work
                                        dd_has_work

Fixes: fbc2a15e ("blk-mq: move cancel of requeue_work into blk_mq_release")
Cc: stable@vger.kernel.org
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0c9c8304

block/blk-mq.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2666,8 +2666,6 @@ void blk_mq_release(struct request_queue *q)
		struct blk_mq_hw_ctx hctx, next;
		int i;

		cancel_delayed_work_sync(&q->requeue_work);

		queue_for_each_hw_ctx(q, hctx, i)
		WARN_ON_ONCE(hctx && list_empty(&hctx->hctx_list));

block/blk-sysfs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -892,6 +892,9 @@ static void __blk_release_queue(struct work_struct *work)

		blk_free_queue_stats(q->stats);

		if (queue_is_mq(q))
		cancel_delayed_work_sync(&q->requeue_work);

		blk_exit_queue(q);

		blk_queue_free_zone_bitmaps(q);

Admin message