Commit e240c183 authored Apr 09, 2014 by Shaohua Li Committed by NeilBrown Apr 09, 2014

raid5: get_active_stripe avoids device_lock

For sequential workload (or request size big workload), get_active_stripe can
find cached stripe. In this case, we always hold device_lock, which exposes a
lot of lock contention for such workload. If stripe count isn't 0, we don't
need hold the lock actually, since we just increase its count. And this is the
hot code path for such workload. Unfortunately we must delete the BUG_ON.

Signed-off-by: Shaohua Li <shli@fusionio.com>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 27c0f68f

drivers/md/raid5.c

+2 −7

Original line number	Diff line number	Diff line
		@@ -679,14 +679,9 @@ get_active_stripe(struct r5conf *conf, sector_t sector,
		init_stripe(sh, sector, previous);
		atomic_inc(&sh->count);
		}
		} else {
		} else if (!atomic_inc_not_zero(&sh->count)) {
		spin_lock(&conf->device_lock);
		if (atomic_read(&sh->count)) {
		BUG_ON(!list_empty(&sh->lru)
		&& !test_bit(STRIPE_EXPANDING, &sh->state)
		&& !test_bit(STRIPE_ON_UNPLUG_LIST, &sh->state)
		);
		} else {
		if (!atomic_read(&sh->count)) {
		if (!test_bit(STRIPE_HANDLE, &sh->state))
		atomic_inc(&conf->active_stripes);
		BUG_ON(list_empty(&sh->lru) &&

Admin message