Commit e22dafbc authored Nov 26, 2005 by Frank Pavlic Committed by Greg Kroah-Hartman Jan 04, 2006

[PATCH] klist: Fix broken kref counting in find functions



The klist reference counting in the find functions that use
klist_iter_init_node is broken.  If the function (for example
driver_find_device) is called with a NULL start object then everything is
fine, the first call to next_device()/klist_next increases the ref-count of
the first node on the list and does nothing for the start object which is
NULL.

If they are called with a valid start object then klist_next will decrement
the ref-count for the start object but nobody has incremented it.  Logical
place to fix this would be klist_iter_init_node because the function puts a
reference of the object into the klist_iter struct.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Frank Pavlic <pavlic@de.ibm.com>
Cc: Patrick Mochel <mochel@digitalimplant.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent bf74ad5b

lib/klist.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -199,6 +199,8 @@ void klist_iter_init_node(struct klist * k, struct klist_iter * i, struct klist_
		i->i_klist = k;
		i->i_head = &k->k_list;
		i->i_cur = n;
		if (n)
		kref_get(&n->n_ref);
		}

		EXPORT_SYMBOL_GPL(klist_iter_init_node);

Admin message