Commit e1f9e0d2 authored Apr 24, 2020 by Tero Kristo Committed by Stephen Boyd May 12, 2020

clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name



clkctrl_get_name incorrectly calls of_node_put when it is not really
doing of_node_get. This causes a boot time warning later on:

[    0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen
t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20

Fix by dropping the of_node_put from the function.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 6c309052 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Link: https://lkml.kernel.org/r/20200424124725.9895-1-t-kristo@ti.com


Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent ce0a9d09

drivers/clk/ti/clkctrl.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -461,7 +461,6 @@ static char * __init clkctrl_get_name(struct device_node *np)
		return name;
		}
		}
		of_node_put(np);

		return NULL;
		}

Admin message