Commit e1e9bdc0 authored Jan 20, 2020 by Jules Irenge Committed by Paul E. McKenney Feb 20, 2020

rcu: Add missing annotation for exit_tasks_rcu_start()



Sparse reports a warning at exit_tasks_rcu_start(void)

|warning: context imbalance in exit_tasks_rcu_start() - wrong count at exit

To fix this, this commit adds an __acquires(&tasks_rcu_exit_srcu).
Given that exit_tasks_rcu_start() does actually call __srcu_read_lock(),
this not only fixes the warning but also improves on the readability of
the code.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

parent fcb73812

kernel/rcu/update.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -801,7 +801,7 @@ static int __init rcu_spawn_tasks_kthread(void)
		core_initcall(rcu_spawn_tasks_kthread);

		/* Do the srcu_read_lock() for the above synchronize_srcu(). */
		void exit_tasks_rcu_start(void)
		void exit_tasks_rcu_start(void) __acquires(&tasks_rcu_exit_srcu)
		{
		preempt_disable();
		current->rcu_tasks_idx = __srcu_read_lock(&tasks_rcu_exit_srcu);

Admin message