Commit e1e71e20 authored Dec 16, 2018 by Greg Kurz Committed by Michael Ellerman Dec 20, 2018

ocxl: Fix endiannes bug in ocxl_link_update_pe()



All fields in the PE are big-endian. Use cpu_to_be32() like everywhere
else something is written to the PE. Otherwise a wrong TID will be used
by the NPU. If this TID happens to point to an existing thread sharing
the same mm, it could be woken up by error. This is highly improbable
though. The likely outcome of this is the NPU not finding the target
thread and forcing the AFU into sending an interrupt, which userspace
is supposed to handle anyway.

Fixes: e948e06f ("ocxl: Expose the thread_id needed for wait on POWER9")
Cc: stable@vger.kernel.org      # v4.18
Signed-off-by: Greg Kurz <groug@kaod.org>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 72e7bcc2

drivers/misc/ocxl/link.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -566,7 +566,7 @@ int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid)

		mutex_lock(&spa->spa_lock);

		pe->tid = tid;
		pe->tid = cpu_to_be32(tid);

		/*
		* The barrier makes sure the PE is updated

Admin message