Commit e1c815f4 authored Aug 07, 2018 by Vinod Koul

soundwire: intel: Fix uninitialized adev deref



In case of error, we can dereference uninitialized 'adev'

drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.

Fix that by not using adev for warn print and make it pr_err.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 30246e2d

drivers/soundwire/intel_init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
		struct acpi_device *adev;

		if (acpi_bus_get_device(handle, &adev)) {
		dev_err(&adev->dev, "Couldn't find ACPI handle\n");
		pr_err("%s: Couldn't find ACPI handle\n", __func__);
		return AE_NOT_FOUND;
		}

Admin message