Commit e1c3e0f8 authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: pm8001: Provide descriptions for the many undocumented 'attr's 

... even if they are completely unused.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/pm8001/pm8001_ctl.c:56: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_mpi_interface_rev_show'
 drivers/scsi/pm8001/pm8001_ctl.c:81: warning: Function parameter or member 'attr' not described in 'controller_fatal_error_show'
 drivers/scsi/pm8001/pm8001_ctl.c:100: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_fw_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:130: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ila_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:155: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_inactive_fw_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:181: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_out_io_show'
 drivers/scsi/pm8001/pm8001_ctl.c:204: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_devices_show'
 drivers/scsi/pm8001/pm8001_ctl.c:230: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_sg_list_show'
 drivers/scsi/pm8001/pm8001_ctl.c:274: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_sas_spec_support_show'
 drivers/scsi/pm8001/pm8001_ctl.c:303: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_host_sas_address_show'
 drivers/scsi/pm8001/pm8001_ctl.c:322: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_logging_level_show'
 drivers/scsi/pm8001/pm8001_ctl.c:355: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_aap_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:390: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ib_queue_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:423: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ob_queue_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:454: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_bios_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:492: warning: Function parameter or member 'attr' not described in 'event_log_size_show'
 drivers/scsi/pm8001/pm8001_ctl.c:510: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_iop_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:548: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_fatal_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:566: warning: Function parameter or member 'attr' not described in 'non_fatal_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:609: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_gsm_log_show'

Link: https://lore.kernel.org/r/20200713080001.128044-11-lee.jones@linaro.org


Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
Acked-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ae272a95

drivers/scsi/pm8001/pm8001_ctl.c

+14 −0
Original line number Diff line number Diff line
@@ -47,6 +47,7 @@ 
/**

 * pm8001_ctl_mpi_interface_rev_show - MPI interface revision number

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -72,6 +73,7 @@ DEVICE_ATTR(interface_rev, S_IRUGO, pm8001_ctl_mpi_interface_rev_show, NULL); 
/**

 * controller_fatal_error_show - check controller is under fatal err

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read only' shost attribute.
@@ -121,6 +123,7 @@ static DEVICE_ATTR(fw_version, S_IRUGO, pm8001_ctl_fw_version_show, NULL); 
/**

 * pm8001_ctl_ila_version_show - ila version

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -146,6 +149,7 @@ static DEVICE_ATTR(ila_version, 0444, pm8001_ctl_ila_version_show, NULL); 
/**

 * pm8001_ctl_inactive_fw_version_show - Inacative firmware version number

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -172,6 +176,7 @@ DEVICE_ATTR(inc_fw_ver, 0444, pm8001_ctl_inactive_fw_version_show, NULL); 
/**

 * pm8001_ctl_max_out_io_show - max outstanding io supported

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -195,6 +200,7 @@ static DEVICE_ATTR(max_out_io, S_IRUGO, pm8001_ctl_max_out_io_show, NULL); 
/**

 * pm8001_ctl_max_devices_show - max devices support

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -221,6 +227,7 @@ static DEVICE_ATTR(max_devices, S_IRUGO, pm8001_ctl_max_devices_show, NULL); 
 * pm8001_ctl_max_sg_list_show - max sg list supported iff not 0.0 for no

 * hardware limitation

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -265,6 +272,7 @@ show_sas_spec_support_status(unsigned int mode, char *buf) 
/**

 * pm8001_ctl_sas_spec_support_show - sas spec supported

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -292,6 +300,7 @@ static DEVICE_ATTR(sas_spec_support, S_IRUGO, 
/**

 * pm8001_ctl_sas_address_show - sas address

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * This is the controller sas address
@@ -346,6 +355,7 @@ static DEVICE_ATTR(logging_level, S_IRUGO | S_IWUSR, 
/**

 * pm8001_ctl_aap_log_show - aap1 event log

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -483,6 +493,7 @@ static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show, NULL); 
/**

 * event_log_size_show - event log size

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs read  shost attribute.
@@ -501,6 +512,7 @@ static DEVICE_ATTR_RO(event_log_size); 
/**

 * pm8001_ctl_aap_log_show - IOP event log

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -538,6 +550,7 @@ static DEVICE_ATTR(iop_log, S_IRUGO, pm8001_ctl_iop_log_show, NULL); 
/**

 ** pm8001_ctl_fatal_log_show - fatal error logging

 ** @cdev:pointer to embedded class device

 ** @attr: device attribute

 ** @buf: the buffer returned

 **

 ** A sysfs 'read-only' shost attribute.
@@ -557,6 +570,7 @@ static DEVICE_ATTR(fatal_log, S_IRUGO, pm8001_ctl_fatal_log_show, NULL); 
/**

 ** non_fatal_log_show - non fatal error logging

 ** @cdev:pointer to embedded class device

 ** @attr: device attribute

 ** @buf: the buffer returned

 **

 ** A sysfs 'read-only' shost attribute.

CRA Git | Maintained and supported by SUSTech CRA and CCSE