Commit e1b702cf authored Mar 14, 2011 by Mike Waychison Committed by Michal Marek Mar 17, 2011

KBuild: silence "'scripts/unifdef' is up to date."



While changing our build system over to use the headers_install target
as part of our klibc build, the following message started showing up in
our logs:

make[2]: `scripts/unifdef' is up to date.

It turns out that the build blindly invokes a recursive make on this
target, which causes make to emit this message when the target is
already up to date.  This isn't seen for most targets as the rest of the
build relies primarily on the default target and on PHONY targets when
invoking make recursively.

Silence the above message when building unifdef as part of
headers_install by hiding it behind a new PHONY target called
"build_unifdef" that has an empty recipe.

Signed-off-by: Mike Waychison <mikew@google.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>

parent 4a5838ad

Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -1022,7 +1022,7 @@ hdr-dst = $(if $(KBUILD_HEADERS), dst=include/asm-$(hdr-arch), dst=include/asm)

		PHONY += __headers
		__headers: include/linux/version.h scripts_basic FORCE
		$(Q)$(MAKE) $(build)=scripts scripts/unifdef
		$(Q)$(MAKE) $(build)=scripts build_unifdef

		PHONY += headers_install_all
		headers_install_all:

scripts/Makefile

+5 −0

Original line number	Diff line number	Diff line
		@@ -18,6 +18,11 @@ always := $(hostprogs-y) $(hostprogs-m)
		# The following hostprogs-y programs are only build on demand
		hostprogs-y += unifdef

		# This target is used internally to avoid "is up to date" messages
		PHONY += build_unifdef
		build_unifdef: scripts/unifdef FORCE
		@:

		subdir-$(CONFIG_MODVERSIONS) += genksyms
		subdir-y += mod
		subdir-$(CONFIG_SECURITY_SELINUX) += selinux

Admin message