Commit e1b44cbe authored Nov 11, 2016 by Robin Murphy Committed by Joerg Roedel Nov 15, 2016

iommu/arm-smmu: Fix group refcounting



When arm_smmu_device_group() finds an existing group due to Stream ID
aliasing, it should be taking an additional reference on that group.
Otherwise, the caller of iommu_group_get_for_dev() will inadvertently
remove the reference taken by iommu_group_add_device(), and the group
will be freed prematurely if any device is removed.

Reported-by: Sricharan R <sricharan@codeaurora.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 13f59a78

drivers/iommu/arm-smmu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1466,7 +1466,7 @@ static struct iommu_group arm_smmu_device_group(struct device dev)
		}

		if (group)
		return group;
		return iommu_group_ref_get(group);

		if (dev_is_pci(dev))
		group = pci_device_group(dev);

Admin message